Repository navigation
fix(cuda.core): include clang-tidy in the build dependency group - #3515
Conversation
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
|
/ok to test bfa2c05 |
|
No actionable comments were generated in the recent review. Summary
Change: Bug fix Merge Risk:
|
|
— codex on behalf of Ralf —
Description
Add Core's existing
clang-tidy==22.1.8pin and Windows ARM64 exclusion to thebuilddependency group. Installing that group now provisions clang-tidy on supported platforms for builds with--no-build-isolation. A missing executable otherwise skips the analysis with a warning.The initial clang-tidy patch in #3272 was already in review on October 28. #3274 added the
buildgroup and both synchronization comments on October 29. The November 3 merge frommainbrought the group and comments into #3272. The clang-tidy pin was still present only in[build-system].requireswhen #3272 landed on November 4. The nearest synchronization comment was outside the final diff hunk, which helps explain how the mismatch could slip through review. Initial clang-tidy commit · November 3 mergeValidation
SKIP=lychee pre-commit run --all-files. The documentation link checker timed out on the first run.Checklist